Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taccsite_custom): texascale social media link #725

Merged
merged 17 commits into from
Oct 4, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 3, 2023

Overview

Support social media share links on Texascale via snippet.

Warning
Causes #739.

Related

Changes

  • changed taccsite_custom pointer

Testing & UI

See TACC/Core-CMS-Resources#193.

@wesleyboar wesleyboar marked this pull request as ready for review October 4, 2023 22:06
@wesleyboar
Copy link
Member Author

The outcome in TACC/Core-CMS-Resources#193 was approved by both designers.

This does not change any other client besides Texascale except for TUP. TUP will just get bigger social media icons.

@wesleyboar wesleyboar merged commit 04b5adf into main Oct 4, 2023
@wesleyboar wesleyboar deleted the feat/tup-87-social-media-share-links-on-texascale branch October 4, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant