-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(taccsite_custom): texascale social media link #725
Merged
wesleyboar
merged 17 commits into
main
from
feat/tup-87-social-media-share-links-on-texascale
Oct 4, 2023
Merged
feat(taccsite_custom): texascale social media link #725
wesleyboar
merged 17 commits into
main
from
feat/tup-87-social-media-share-links-on-texascale
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking Change: Any existing use of these will show them Npx larger.* * E.g. TACC footer.
And allow text after. And allow removing either text.
This was referenced Oct 3, 2023
The outcome in TACC/Core-CMS-Resources#193 was approved by both designers. This does not change any other client besides Texascale except for TUP. TUP will just get bigger social media icons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support social media share links on Texascale via snippet.
Related
Changes
Testing & UI
See TACC/Core-CMS-Resources#193.